Don't create accounts::home_dir resources

[arjenz]

Even with managehome set to false, accounts::home_dir resources need to be unique, implying all managed users should have a unique homedir. On default CentOS (and probably others) installs some system users share / as homedir.

Don't create a accounts::home_dir resource when managehome
is set to false.

[hunner]

@arjenz Hmm. It looks like if managehome => false then accounts::home_dir really does nothing other than raise a warning when ssh keys are passed (https://github.com/puppetlabs/puppetlabs-accounts/blob/1.2.1/manifests/home_dir.pp#L131-L133). So that means this change is appropriate and should simplify the home_dir define logic :D.

Could you remove the parameter and references to $managehome from accounts::home_dir and move that ssh key warning up to user.pp? That will also fix the failing tests. Thanks!

[arjenz]

@hunner Done!

[hunner]

Thanks!