Allow mode for homedir to be undef #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arjenz Please alter the docs so that your change is reflected in them. |
|
@david22swan Done |
Default `mode` for `accounts::home_dir` to undef. If `accounts::user` accepts and defaults to undef, so should `accounts::home_dir`.
Change docs to reflect behavior and new default setting of `home_mode`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default
modeforaccounts::home_dirto undef. Ifaccounts::useraccepts and defaults to undef, so should
accounts::home_dir.This way
manage_homecan still be true so puppet will create homedir (based on umask) and manage sshkeys in it, while allowing users to manage their own permissions if we don't explicitly specify mode when creatingaccounts::userresource.