(MODULES-8909) Add type-aliases and auto-loading.

[pillarsdotnet]

Adds defined type-aliases for some parameters to the Accounts::User resource type and accounts auto-loading per MODULES-8909.

[smortex]

Let me detail the reason for the downvote.

Optional[Foo] vs. Foo hiding it is Optional

A quick glance at the parameters list does not help in figuring out which parameters are required and which parameters are optional. I feel like defined types should not not say their value is optional, and Optional[] should be put when using the type when applicable.

That way, those defined types can be reused more easily if it makes sense in another module where it is required.

Boolean $system = false vs. Accounts::User::System $system = false

IMO this kind of change does not improve readability, and makes it more complex to understand that this parameter expect a Booolean, especially if no default value was set.

Some parameters do benefit from aliases though, mostly those using regular expressions, e.g. Pattern[/^\/$|^\/.*[^\/]$/] vs. Stdlib::Unixpath, but I feel it is better to make the possible values obvious instead of hiding them behind a custom type, e.g. Pattern[/^absent$|^\d{4}-\d{2}-\d{2}$/] (makes me think) vs. Accounts::User::Expiry (makes me think hard the first time I see it, straightforward the next times until I forgot about this) vs. Variant[Enum['absent'], ISO8601Date] (makes me think a little every time).

[pillarsdotnet]

@smortex -- Thanks for the review. I have tried to follow all your suggestions.

Ready for another look?

[smortex]

IMO the interface looks a lot friendlier to use, thanks!

[smortex]

That looks great, @pillarsdotnet.

I am not a collaborator to this project (I don't recall how I reach this PR, I just wanted to give feedback), so you'll have to wait for some project owner to review and merge this 😉

[eimlav]

Hi @pillarsdotnet . Thanks for adding these new types. They should be a great new feature for the module! Would it be possible to update your commit message to include your ticket number (see CONTRIBUTING.md). Since there are a number of new types added, these all require unit tests as well as Puppet Strings documentation. If you are looking for examples of how to do testing on type aliases, see stdlib testing.

Let me know if you have any questions. Cheers!

[eimlav]

@pillarsdotnet Great stuff! All this needs now is a few README updates to document the new types. Something along the lines of this should suffice. After that it should be ready to go :)

[pillarsdotnet]

Passes all tests and ready for final review by @eimlav and/or @DavidS

[eimlav]

Some minor changes. Also ensure to run Puppet Strings to regenerate the REFERENCE.md. See here for more info on this.

[tphoney]

@pillarsdotnet phenomenal work. Best PR i have seen in a while !!

[eimlav]

Adhoc ran successfully:

See here for results

Fantasic work @pillarsdotnet ! I'm happy to merge this now if you are @tphoney ?

[tphoney]

great work !!