Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-8909) Allow periods in usernames. #220

Merged
merged 1 commit into from
May 1, 2019
Merged

(MODULES-8909) Allow periods in usernames. #220

merged 1 commit into from
May 1, 2019

Conversation

pillarsdotnet
Copy link
Contributor

@pillarsdotnet pillarsdotnet commented Apr 30, 2019 •
edited
Loading

As requested:

JakeZ
So I suppose it would be bad form to allow usernames that have a . in it according to your note on https://github.com/puppetlabs/puppetlabs-accounts/blob/master/types/user/name.pp
ie: user.name, first.last, robert.vincent

Robert Vincent
Thus saith Ubuntu, anyway.

JakeZ
that is unfortunate as 95% of ours are the . syntax

@pillarsdotnet pillarsdotnet changed the title Allow periods in usernames. (MODULES-8909) Allow periods in usernames. Apr 30, 2019
@pillarsdotnet
Copy link
Contributor Author

Reopened MODULES-8909.

@eimlav eimlav added the bugfix label May 1, 2019
@eimlav
Copy link
Contributor

eimlav commented May 1, 2019

LGTM. Thanks @pillarsdotnet for adding this fix!

@eimlav eimlav merged commit 98d1540 into puppetlabs:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pillarsdotnet @eimlav