Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-7469) Add password_max_age parameter #221

Merged
merged 2 commits into from
May 13, 2019
Merged

(MODULES-7469) Add password_max_age parameter #221

merged 2 commits into from
May 13, 2019

Conversation

eimlav
Copy link
Contributor

@eimlav eimlav commented May 1, 2019

No description provided.

@eimlav eimlav added the feature label May 1, 2019
@eimlav eimlav changed the title (MODULES-7469) Add password_max_age parameter [WIP] (MODULES-7469) Add password_max_age parameter May 2, 2019
@eimlav eimlav mentioned this pull request May 3, 2019
Merged
pillarsdotnet
pillarsdotnet reviewed May 10, 2019
View reviewed changes
manifests/user.pp Outdated Show resolved Hide resolved
pillarsdotnet
pillarsdotnet suggested changes May 10, 2019
View reviewed changes
Copy link
Contributor

@pillarsdotnet pillarsdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the one missed type-alias.

@eimlav
Copy link
Contributor Author

eimlav commented May 13, 2019

Adhoc ran successfully:

See results hereScreen Shot 2019-05-13 at 13 59 44

@eimlav eimlav changed the title [WIP] (MODULES-7469) Add password_max_age parameter (MODULES-7469) Add password_max_age parameter May 13, 2019
@sheenaajay sheenaajay merged commit 0777075 into puppetlabs:master May 13, 2019
@carabasdaniel
Copy link
Contributor

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pillarsdotnet pillarsdotnet pillarsdotnet requested changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eimlav @carabasdaniel @pillarsdotnet @sheenaajay