MODULES-9447 -- Narrow dependency between removed user and group.

[pillarsdotnet]

(MODULES-9447) Unfortunately, we still have some issues with dependency cycles when removing accounts.

This line was added to ensure that we don't remove a user's primary group before removing a user:

User[$name] -> Group <| |>

This causes a dependency cycle whenever any code in the same run requires any group, and must run before the user is deleted. For instance, if an exec is used to backup a homedir before deletion, and the exec is run as user and group root, then a dependency cycle is created.

At a minimum, the dependency should be narrowed to:

User[$name] -> Group <| ensure == 'absent' |>

The included acceptance tests fails without the above change, and passes with it.

[carabasdaniel]

Hello @pillarsdotnet,

I've ran the acceptance tests on CentOS, Debian and Ubuntu and apparently there is one test that is failing with the following error:

`

1. accounts::user define create duplicate users with same uid runs with no errors
   On host localhost:2223' Failure/Error: apply_manifest(pp_user_with_duplicate_uid, catch_failures: true) RuntimeError: {"_error"=>{"kind"=>"puppetlabs.tasks/connect-error", "msg"=>"Authentication failed for user root@localhost", "details"=>{}, "issue_code"=>"AUTH_ERROR"}}
   Could you please fix the PR to make sure that all the acceptance tests are passing ?

Thanks.

[pillarsdotnet]

... Could you please fix the PR to make sure that all the acceptance tests are passing ? ...

@carabasdaniel -- I can't replicate your error, but have modified the acceptance test slightly. Hopefully it will both demonstrate the bug and resolve your error.

[carabasdaniel]

@pillarsdotnet Thanks for the quick reply, trying it out now.

[pillarsdotnet]

@carabasdaniel -- You might want to wait until the acceptance tests pass in Travis-CI first...

[carabasdaniel]

👍 Looks good.