Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-9712) Move data into hiera. #241

Merged
merged 3 commits into from
Aug 13, 2019
Merged

(MODULES-9712) Move data into hiera. #241

merged 3 commits into from
Aug 13, 2019

Conversation

pillarsdotnet
Copy link
Contributor

@pillarsdotnet pillarsdotnet commented Aug 7, 2019 •
edited
Loading

Current best-practice is to move os-specific data from manifests into hiera.

Fixes MODULES-9712.

@pillarsdotnet pillarsdotnet force-pushed the module_data branch 14 times, most recently from b7b025d to 08603c9 Compare August 7, 2019 20:44
@ThoughtCrhyme
Copy link
Contributor

Hi @pillarsdotnet thanks for the PR. The tests are failing with Error while evaluating a Resource Statement, Duplicate declaration: Notify[osfamily] is already declared at (file: /etc/puppetlabs/code/environments/production/modules/accounts/manifests/user.pp, line: 215).

Once we can get those to pass we can merge this PR.

@pillarsdotnet
Copy link
Contributor Author

pillarsdotnet commented Aug 12, 2019 •
edited
Loading

@ThoughtCrhyme -- I'm aware; I've been making changes locally and re-testing.

@pillarsdotnet pillarsdotnet force-pushed the module_data branch 14 times, most recently from 94a5f5b to 85a65d9 Compare August 12, 2019 21:55
@pillarsdotnet pillarsdotnet force-pushed the module_data branch 10 times, most recently from b085a44 to 4a3b375 Compare August 13, 2019 17:28
@pillarsdotnet pillarsdotnet changed the title Move data into hiera. (MODULES-9712) Move data into hiera. Aug 13, 2019
@pillarsdotnet
Copy link
Contributor Author

pillarsdotnet commented Aug 13, 2019 •
edited
Loading

@ThoughtCrhyme @tuxmea Tests now pass; care to review?

@pillarsdotnet pillarsdotnet force-pushed the module_data branch 2 times, most recently from a21c480 to 4a3b375 Compare August 13, 2019 20:07
@ThoughtCrhyme ThoughtCrhyme merged commit 4480ff2 into puppetlabs:master Aug 13, 2019
@pillarsdotnet pillarsdotnet deleted the module_data branch August 14, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofHajdamowicz KrzysztofHajdamowicz KrzysztofHajdamowicz left review comments

@ThoughtCrhyme ThoughtCrhyme ThoughtCrhyme approved these changes

Assignees
No one assigned
Labels
backwards-incompatible feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pillarsdotnet @ThoughtCrhyme @KrzysztofHajdamowicz