-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODULES-10862 add support for authorized_keys file mode #338
Conversation
accounts::key_management is a typethat may have no external impact to Forge modules. accounts::user is a typeBreaking changes to this file WILL impact these 3 modules (exact match):Breaking changes to this file MAY impact these 4 modules (near match):This module is declared in 3 of 575 indexed public
|
|
@david22swan the travis-ci failure are not due to my change so I'd appreciate if you could still take a look ;) (you've been helpful in the past, hence the direct ping to you, thanks) |
|
@simondeziel Sorry for the wait. |
That was quite fast actually, so thanks!
I had already added tests that passed ;) I'll rebase once #339 is merged and hopefully that will trigger another round of tests. Thanks! |
Signed-off-by: Simon Deziel <simon@sdeziel.info>
Signed-off-by: Simon Deziel <simon@sdeziel.info>
accounts::key_management is a typethat may have no external impact to Forge modules. accounts::user is a typeBreaking changes to this file WILL impact these 3 modules (exact match):Breaking changes to this file MAY impact these 4 modules (near match):This module is declared in 3 of 575 indexed public
|
|
@david22swan please let me know if I missed anything, thanks! |
|
@simondeziel |
|
@david22swan thanks! Sorry I got confused by acceptance vs unit tests. I'll keep that in mind for future contributions. |
No description provided.