Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new SSH key type. #410

Merged
merged 2 commits into from
May 16, 2022
Merged

Added new SSH key type. #410

merged 2 commits into from
May 16, 2022

Conversation

PorkCharsui79
Copy link
Contributor

Added the sk-ssh-ed25519 SSH key type.

@PorkCharsui79
Added new SSH key type.
516b2df 
Added the sk-ssh-ed25519 SSH key type.
@PorkCharsui79 PorkCharsui79 requested a review from a team as a code owner May 11, 2022 14:10
@puppet-community-rangefinder
Copy link

accounts_ssh_authorized_keys_line_parser is a function

Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 3 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented May 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@PorkCharsui79
Update accounts_ssh_authorized_keys_line_parser.rb
230d072 
I'm sorry, you are right. I fixed it.
@chelnak chelnak merged commit 53fa9cb into puppetlabs:main May 16, 2022
@chelnak
Copy link
Contributor

chelnak commented May 16, 2022

Closes #410

@chelnak
Copy link
Contributor

chelnak commented May 16, 2022

@PorkCharsui79 Thanks for your contribution! 🥳

@chelnak chelnak linked an issue May 16, 2022 that may be closed by this pull request
Add support for sk-ssh-ed25519 keys #409
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for sk-ssh-ed25519 keys
5 participants
@PorkCharsui79 @CLAassistant @chelnak @kenyon @ia-content