Remove workaround from user.pp #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue referenced in the workaround (https://tickets.puppetlabs.com/browse/PUP-9706) has been closed and puppetlabs/puppet#7527 was merged to address the underlying issue. Therefore this workaround should no longer be needed and the `managehome` option should be customizable. Full issue description reported here puppetlabs#438
|
|
accounts::user is a typeBreaking changes to this file WILL impact these 3 modules (exact match):Breaking changes to this file MAY impact these 5 modules (near match):This module is declared in 3 of 580 indexed public
|
Remove tests for managehome = false
If managehome is set to true, prevent the purge_user_home from attempting to delete the home dir
|
Could I get some feedback on this when possible? Thank You! |
|
This makes sense to me. Sorry for the long delay in feedback, we have been busy with Puppet 8 compatibility. Happy enough to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue referenced in the workaround (https://tickets.puppetlabs.com/browse/PUP-9706) has been closed and puppetlabs/puppet#7527 was merged to address the underlying issue. Therefore this workaround should no longer be needed and the
managehomeoption should be customizable.Full issue description reported here #438