(MODULES-11458) Revert deferred function #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested changes
Jul 24, 2024
bastelfreak
reviewed
Jul 24, 2024
| end | ||
|
|
||
| def user_password(password) | ||
| password |
There was a problem hiding this comment.
did this just return the content of the password variable?
There was a problem hiding this comment.
yeah, it returns as it is.
We have implemented based on earlier understanding and handover but I feel probably we are missing something here. That is one reason I am reverting.
Also there is customer reported issue where /etc/shadow is getting populting with "Deferred({'name' => 'user_password', 'argume... content.
There was a problem hiding this comment.
I am having this exact issue currently after updating the accounts module. Rolling back in our environment until this is fixed.
cat /etc/shadow
...
admin:Deferred({'name' => 'user_password', 'arguments' => ['$6$OLbl..snip..gPrlY.']}):19943:0:99999:7:::
...
bastelfreak
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Revert deferred function
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)