Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow duplicate keys to be associated with multiple accounts. #54

Merged
merged 1 commit into from Nov 22, 2016
Merged

Allow duplicate keys to be associated with multiple accounts. #54

merged 1 commit into from Nov 22, 2016

Conversation

ian-d
Copy link
Contributor

@ian-d ian-d commented May 2, 2016

Should address #53. Squashed and resubmitted because of build failure, but travis builds are also currently failing against master, too, so I'm going to call it an rspec/travis/something else problem.

Build will fail with:

Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown variable: '::osfamily'.

@cdenneen
Copy link

cdenneen commented May 3, 2016

@bmjen can you look at this?

@ian-d
Copy link
Contributor Author

ian-d commented May 3, 2016

Build should be fixed by PR #55.

@nparley
Copy link

nparley commented Jul 22, 2016

+1

@spezam
Copy link

spezam commented Sep 21, 2016

+1
#54 has been on hold for a while, any chance to get this pushed either to master or a tag

@mrbanzai
Copy link

mrbanzai commented Nov 1, 2016

+1

@eputnam eputnam merged commit c420138 into puppetlabs:master Nov 22, 2016
@ian-d ian-d deleted the duplicatekeys branch November 22, 2016 19:53
@eputnam
Copy link
Contributor

eputnam commented Nov 22, 2016

Doesn't pass spec tests for Puppet 3.8.7, which went undetected because this PR was created before those tests were part of our standard travis barrage. Please re-open changes against master.

@ssanden
Copy link

ssanden commented Feb 9, 2017

the last two releases of this module declare compatibilty for:

Puppet >= 4.0.0 < 5.0.0

why does it need to comply to tests for Puppet 3.8.7, then?
personally, i'd much rather have this duplicate-keys bug fixed instead.

greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants