Group name #85
Merged
Group name #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wpowell-oss thanks for the PR, it looks sane and you have edited the readme and tests. Could you have a look at the failing tests, as i cannot merge until these pass. |
|
Ahhh...that would be because I had removed the code to create a .vim directory. That was not meant to be in this PR, so I'll reinstate it and update. |
|
Another minor nitpick, you have also edited the gemfile. I dont think this is necessary for this PR |
|
Gemfile reinstated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for an account to be created with a custom primary group name that does not match the user name that could be used for multiple users such as 'staff' or 'users'.
Specifying the GID is still valid, along with the group name and this PR also handles group removal if the group name matches the user name only.
Additional examples provided, along with bug fixes for existing examples.