-
Notifications
You must be signed in to change notification settings - Fork 57
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-acl
base: 2.0.0
head repository: puppetlabs/puppetlabs-acl
compare: 2.0.1
- 15 commits
- 13 files changed
- 5 contributors
Commits on May 23, 2017
-
* release: (MODULES-4918) Prepare module for 2.0.0 release (MODULES-4920) pre-release README fixes (MODULES-4918) Prepare module for 1.2.0 release (MODULES-4838) Update puppet compatibility with 4.7 as lower bound
Configuration menu - View commit details
-
Copy full SHA for 4a37b05 - Browse repository at this point
Copy the full SHA 4a37b05View commit details
Commits on May 25, 2017
-
(MODULES-4976) Remove rspec configuration for win32_console
Previously the spec_helper would configure rspec to output all to STDOUT due to issues with the win32_console gem. However as that gem was removed in Puppet 4, it is no longer required. Also by redirecting to stdout, when using the junit formatter, the output is sent to STDOUT instead of the specificed text file. This commit removes the redundant rspec configuration.
Configuration menu - View commit details
-
Copy full SHA for d9b37bd - Browse repository at this point
Copy the full SHA d9b37bdView commit details -
Merge pull request #102 from glennsarti/ticket/master/modules-4976-fi…
…x-rspec Previously the spec_helper would configure rspec to output all to STDOUT due to issues with the win32_console gem. However as that gem was removed in Puppet 4, it is no longer required. Also by redirecting to stdout, when using the junit formatter, the output is sent to STDOUT instead of the specificed text file. This commit removes the redundant rspec configuration.
Configuration menu - View commit details
-
Copy full SHA for 312a87b - Browse repository at this point
Copy the full SHA 312a87bView commit details
Commits on Jun 26, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7320b5e - Browse repository at this point
Copy the full SHA 7320b5eView commit details -
Merge pull request #103 from hunner/bump_metadata
(MODULES-5144) Prep for puppet 5
Configuration menu - View commit details
-
Copy full SHA for 1e26132 - Browse repository at this point
Copy the full SHA 1e26132View commit details
Commits on Jul 25, 2017
-
(MODULES-5187) mysnc Ruby 2.4 / Puppet 5 / ubergem
- Although some of the changes in this PR should be independent, it was necessary to combine them to get a passing commit, given the timeline of some related releases. - rspec-puppet introduced some monkey patching in 2.6.0 which breaks Windows on Windows testing - introduced in rodjek/rspec-puppet#498 - AppVeyor won't demonstrate the problem given Puppet 4.2.3 has been removed from the matrix, but this PR also pins puppet-module-win-dev-r21 back to `0.0.7` for a few reasons. 0.0.8+ doesn't work properly in Jenkins due to the addition of rspec-puppet-facts which requires json and triggers compilation of a native extension in spec environments without compilers. The 0.0.9 / 0.0.10 releases include a dependency on metadata-json-list 2.0.0+ which requires Puppet 4.7+ - Finally, the behavior of Puppet format_value_for_display changed in Puppet 5, which produces different output for change notifications and `puppet resource` in Puppet 5. This module will likely need to be refactored later to simplify the use of Ruby types (to remove Ace deriving from Hash), but for now, changing just the test to accurately portray Puppet behavior is sufficient.
Configuration menu - View commit details
-
Copy full SHA for 6333f0b - Browse repository at this point
Copy the full SHA 6333f0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ebdcaa - Browse repository at this point
Copy the full SHA 7ebdcaaView commit details -
(MODULES-5152) APPLICATION PACKAGE AUTHORITY tests
- Use manifests to prove that the ACL mdoule can properly handle the identities in APPLICATION PACKAGE AUTHORITY - namely S-1-15-2-1 / ALL APPLICATION PACKAGES and S-1-15-2-2 / ALL RESTRICTED APPLICATION PACKAGES. Note that accounts in APPLICATION PACKAGE AUTHORITY are handled strangely in the Windows API, and are not resolvable when fully qualified with the LookupAccountName like other accounts are. Therefore there are no tests showing that the fully qualified name actually works, and the README for this module will be updated accordingly.
Configuration menu - View commit details
-
Copy full SHA for 36e7efc - Browse repository at this point
Copy the full SHA 36e7efcView commit details -
(MODULES-5152) Fix ACE mutation on output
- Existing code mutates an Ace instance in the methods used to emit string versions of Ace objects - permissions_should_to_s and permissions_to_s. In particular, the `ALL APPLICATION PACKAGES` group is special as it must be specified without the leading `APPLICATION PACKAGE AUTHORITY` to properly resolve to a SID with the Windows API. Previously, for the sake of outputting the name of the group to users in the output of change messages / `puppet resource`, a SID name would be resolved to a complete name like `APPLICATION PACKAGE AUTHORITY\ALL APPLICATION PACKAGES` *and* the original Ace instance would be mutated causing future misbehavior as a result. - Previously permissions_to_s produced an Array of Puppet::Type::Acl::Ace objects, but now produces an Array of Ruby Hash objects, which can still be turned into log messages just fine. Puppet 5 in particular changed how values are logged to display to support arbitrarily nested structures. - Update documentation for how to use these accounts correctly. - Add integration tests for APPLICATION PACKAGES - though these unfortunately do not prove that the accounts can be used in a real manifest.
Configuration menu - View commit details
-
Copy full SHA for 4c73468 - Browse repository at this point
Copy the full SHA 4c73468View commit details
Commits on Jul 27, 2017
-
Merge pull request #105 from Iristyle/ticket/MODULES-5152-error-with-…
…ALL-APPLICATION-PACKAGES (MODULES-5152) Fix ACE mutation on output
Configuration menu - View commit details
-
Copy full SHA for 6eac937 - Browse repository at this point
Copy the full SHA 6eac937View commit details
Commits on Jul 31, 2017
-
Merge remote-tracking branch 'origin/master' into ticket/MODULES-5364…
…-prep-for-2.0.1-release * origin/master: (MODULES-5152) Fix ACE mutation on output (MODULES-5152) APPLICATION PACKAGE AUTHORITY tests (maint) Fix invalid Markdown / typos (MODULES-5187) mysnc Ruby 2.4 / Puppet 5 / ubergem (MODULES-5144) Prep for puppet 5 (MODULES-4976) Remove rspec configuration for win32_console
Configuration menu - View commit details
-
Copy full SHA for e5ad638 - Browse repository at this point
Copy the full SHA e5ad638View commit details -
(MODULES-5364) Prepare module for 2.0.1 release
- Fixes issue MODULES-5152 to properly support ALL APPLICATION PACKAGES and ALL RESTRICTED APPLICATION PACKAGES from the APPLICATION PACKAGE AUTHORITY
Configuration menu - View commit details
-
Copy full SHA for 2458da8 - Browse repository at this point
Copy the full SHA 2458da8View commit details -
Merge pull request #108 from Iristyle/ticket/MODULES-5364-prep-for-2.…
…0.1-release (MODULES-5364) Prepare module for 2.0.1 release
Configuration menu - View commit details
-
Copy full SHA for 094760d - Browse repository at this point
Copy the full SHA 094760dView commit details
Commits on Aug 1, 2017
-
(MODULES-5364) Adjust Puppet 4.10+ acceptance
- Puppet 4.10+ has changed the attribute ordering in messages due to internal changes around Puppet formatting code
Configuration menu - View commit details
-
Copy full SHA for 0284928 - Browse repository at this point
Copy the full SHA 0284928View commit details
Commits on Aug 2, 2017
-
Merge pull request #109 from Iristyle/task/release/MODULES-5364-fix-a…
…cceptance (MODULES-5364) Adjust Puppet 4.10+ acceptance
Erick Banks authoredAug 2, 2017 Configuration menu - View commit details
-
Copy full SHA for 611a39a - Browse repository at this point
Copy the full SHA 611a39aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.0.0...2.0.1