(MODULES-5364) All version negative/prop_file fix #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0284928 made a naive fix to the acceptance test negative/prop_file
under the assumption that the test output changed based on just
recent module changes in 4c73468.
In reality, the 4c73468 bugfix changed how the output appears in
both Puppet 4 and Puppet 5, as Puppet 5 changed formatting around
basic Ruby types.
That bugfix stopped emitting a [Puppet::Type::Acl::Ace] and instead
emits a [Hash] representing Aces.
Those formatting changes apply to
pupept applyandpuppet agentfor the ACL module, but not for
puppet resource.The test updates in this commit vary how output is checked based
on which version of Puppet the test is running on.
For Puppet 4, the manifest application emits a message like:
For Puppet 5, the manifest application emits a mesaage like:
be dedicated to some refactorings around the type structure inside
the module.