Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Remove skip_test on Unicode tests #111

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
2 participants
@Iristyle
Copy link
Member

commented Aug 19, 2017

  • Some test could simply have their skip_test removed

  • For some tests dir /q didn't return owner in the format we'd like
    and instead moved to PowerShell Get-Acl command which has better
    filtering / formatting capabilities

  • For the unicode_dir and unicode_file tests, their checks had to
    be rewritten in a more saavy way. While it wasn't possible to pass
    Unicode strings through the shell when performing a cat or dir
    it was possible to have PowerShell perform queries and return the
    name of the directory or file through SSH properly.

    In these cases, assertions could be slightly rewritten to instead
    match on a filename that matched criteria, rather than matching on
    the output of a command like icacls.

(maint) Remove skip_test on Unicode tests
 - Some test could simply have their skip_test removed
 - For some tests dir /q didn't return owner in the format we'd like
   and instead moved to PowerShell Get-Acl command which has better
   filtering / formatting capabilities
 - For the unicode_dir and unicode_file tests, their checks had to
   be rewritten in a more saavy way. While it wasn't possible to pass
   Unicode strings through the shell when performing a `cat` or `dir`
   it was possible to have PowerShell perform queries and return the
   name of the directory or file through SSH properly.

   In these cases, assertions could be slightly rewritten to instead
   match on a filename that matched criteria, rather than matching on
   the output of a command like icacls.
@Iristyle

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2017

Verified as passing locally by executing command:

PUPPET_AGENT_SHA=370d0901a9696fd329156541d22163795cc5fe2d PUPPET_AGENT_SUITE_VERSION=1.10.6.20.g370d090 PUPPET_INSTALL_TYPE=agent bundle exec beaker --options-file acceptance/.beaker-git.cfg --hosts hosts.yaml --tests acceptance/tests/group/group_local_unicode_group.rb,acceptance/tests/group/group_local_unicode_user.rb,acceptance/tests/identity/specify_unicode_group_ident.rb,acceptance/tests/identity/specify_unicode_user_ident.rb,acceptance/tests/owner/owner_local_unicode_group.rb,acceptance/tests/owner/owner_local_unicode_user.rb,acceptance/tests/parameter_target/add_perms_to_unicode_dir.rb,acceptance/tests/parameter_target/add_perms_to_unicode_file.rb

Results:

     Test Suite: tests @ 2017-08-18 19:45:43 -0700

      - Host Configuration Summary -


              - Test Case Summary for suite 'tests' -
       Total Suite Time: 109.88 seconds
      Average Test Time: 13.74 seconds
              Attempted: 8
                 Passed: 8
                 Failed: 0
                Errored: 0
                Skipped: 0
                Pending: 0
                  Total: 8
@Iristyle

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2017

QENG-449 became BKR-42

@jpogran jpogran merged commit a942751 into puppetlabs:master Aug 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Iristyle Iristyle deleted the Iristyle:maint/enable-unicode-tests branch Aug 24, 2017

@Iristyle

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2017

This has discovered a bug in Puppet 5 - ticket filed at https://tickets.puppetlabs.com/browse/PUP-7880 / PR at puppetlabs/puppet#6156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.