(IAC-1089) Remove dependency on 'win32/security' gem for Puppet 7 compatibility #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `win32` gems were removed from `puppet-runtime` in puppetlabs/puppet-runtime#364 We have not been using this gem for some time, so it can be safely removed.
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 84.32% 84.29% -0.03%
==========================================
Files 5 5
Lines 708 707 -1
==========================================
- Hits 597 596 -1
Misses 111 111
Continue to review full report at Codecov.
|
|
Tests against Puppet 6: |
|
Tests against Puppet 5: |
sheenaajay
approved these changes
Aug 21, 2020
sanfrancrisko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
win32gems were removed frompuppet-runtimeinpuppetlabs/puppet-runtime#364
We have not been using this gem for some time, so it can be safely
removed.