Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CONT-686) - Add Puppet 8/Drop Puppet 6 #279

Merged
merged 37 commits into from
Apr 19, 2023
Merged

(CONT-686) - Add Puppet 8/Drop Puppet 6 #279

merged 37 commits into from
Apr 19, 2023

Conversation

jordanbreen28
Copy link
Contributor

This PR ensures the puppetlabs-acl module's compatibility with puppet 8.
Also drops support for puppet 6.

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner April 18, 2023 09:46
@puppet-community-rangefinder
Copy link

acl is a type

Breaking changes to this file WILL impact these 13 modules (exact match):
Breaking changes to this file MAY impact these 6 modules (near match):

This module is declared in 4 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jordanbreen28
(CONT-686) - Correct Layout/HashAlignment
83edf9a
@jordanbreen28
(CONT-686) - Correct Lint/DuplicateRegexpCharacterClassElement
673442f
@jordanbreen28
(CONT-686) - Correct Lint/NonAtomicFileOperation
1ca3935
@jordanbreen28
(CONT-686) - Correct Lint/RedundantCopDisableDirective
d22c53a
@jordanbreen28
(CONT-686) - Correct Lint/RedundantCopEnableDirective
a4bd31e
@jordanbreen28
(CONT-686) - Correct Lint/RedundantSafeNavigation
463f012
@jordanbreen28
(CONT-686) - Correct Naming/RescuedExceptionsVariableName
768b1aa
@jordanbreen28
(CONT-686) - Correct Performance/StringInclude
e3efd0c
@jordanbreen28
(CONT-686) - Correct RSpec/BeEq
c656e48
@jordanbreen28
(CONT-686) - Correct RSpec/ContextMethod
86daea4
@jordanbreen28
(CONT-686) - Correct RSpec/EmptyLineAfterExample
e7ede83
@jordanbreen28
(CONT-686) - Correct RSpec/ExcessiveDocstringSpacing
09b6433
@jordanbreen28
(CONT-686) - Correct RSpec/ReceiveNever
339e795
@jordanbreen28
(CONT-686) - Correct Security/CompoundHash
16f7bca
@jordanbreen28
(CONT-686) - Pin puppet_agent v4.13.0
6ab3bdc
@jordanbreen28
(CONT-686) - Correct Style/AccessorGrouping
b672845
@jordanbreen28 jordanbreen28 self-assigned this Apr 18, 2023
LukasAud
LukasAud approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 31ffde2 into main Apr 19, 2023
@LukasAud LukasAud deleted the CONT-686-add_puppet8_support branch April 19, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

Assignees

@jordanbreen28 jordanbreen28

Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanbreen28 @LukasAud