-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-apache
base: v8.0.0
head repository: puppetlabs/puppetlabs-apache
compare: v8.1.0
- 18 commits
- 25 files changed
- 8 contributors
Commits on Aug 9, 2022
-
Allow custom_config to have a string priority again
In f41251e the type was narrowed to no longer allow strings, but this can cause problems. Sorting is alphabetical and you need to format it for the correct sorting. So to make sure 2 loads before 10 you need to format it as 02. While the vhost can do some printf style magic to change 2 to 02, it must then also know what the highest number is. Otherwise 100 is sorted before 20. By allowing strings, you allow the caller to fix this. A type alias is introduced to reduce duplication and make it easier to track. Fixes: f41251e
Configuration menu - View commit details
-
Copy full SHA for b43350c - Browse repository at this point
Copy the full SHA b43350cView commit details
Commits on Aug 10, 2022
-
fix duplicate definition of auth_basic-mod
PR 2252 breaks the usage of auth_basic in a vhost, because the module is declared twice: Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Apache::Mod[auth_basic] is already declared at (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/default_mods.pp, line: 142); cannot redeclare (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/mod/auth_basic.pp, line: 7) (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/mod/auth_basic.pp, line: 7, column: 3) (file: /etc/puppetlabs/code/environments/module_updates/site-modules/rx_apache/manifests/vhost.pp, line: 336) on node ... fix it by including the appropriate class in defaults_mods, instead of just defining the module
Configuration menu - View commit details
-
Copy full SHA for 52371a9 - Browse repository at this point
Copy the full SHA 52371a9View commit details -
Merge pull request #2287 from sircubbi/bugfix_authbasic_module_after_…
…pr2252 fix duplicate definition of auth_basic-mod
Configuration menu - View commit details
-
Copy full SHA for 921de9e - Browse repository at this point
Copy the full SHA 921de9eView commit details -
Merge pull request #2284 from martin-koerner/custom_config_prio
Allow custom_config to have a string priority again
Configuration menu - View commit details
-
Copy full SHA for e1f9cae - Browse repository at this point
Copy the full SHA e1f9caeView commit details -
Include apache::mod::authn_core in every auth mod
The authn_core module is needed for AuthType, which is needed to select a specific auth. While modules may load without them, it's unlikely to work in practice. This is only relevant when default mods are disabled since authn_core is a default module.
Configuration menu - View commit details
-
Copy full SHA for 985d959 - Browse repository at this point
Copy the full SHA 985d959View commit details -
Manage DNF module for mod_auth_openidc
On EL 8 mod_auth_openidc is in a DNF module that must be enabled. Otherwise the package is uninstallable. This is verified by adding an acceptance test for the class. The inheritance on apache::params is removed since it was redundant. That is only needed if a class parameter uses apache::params. $oidc_settings on apache::vhost is changed to have a default. The template expects one and With that it's impossible to miscompile. The alternative is to implement a fail() inside the code if it is empty, but this provides some safety.
Configuration menu - View commit details
-
Copy full SHA for 8417c0b - Browse repository at this point
Copy the full SHA 8417c0bView commit details
Commits on Aug 11, 2022
-
Remove auth_kerb and nss from Debian Bullseye
libapache2-mod-auth-kerb is unavailable in Debian Bullseye[1] libapache2-mod-auth-kerb was removed in Debian Buster[2] [1]: https://packages.debian.org/buster/libapache2-mod-auth-kerb [2]: https://packages.debian.org/stretch/libapache2-mod-nss
Configuration menu - View commit details
-
Copy full SHA for 9044b4c - Browse repository at this point
Copy the full SHA 9044b4cView commit details -
Merge pull request #2281 from ekohl/remove-removed-mods
Remove auth_kerb and nss from Debian Bullseye
Configuration menu - View commit details
-
Copy full SHA for b0fff67 - Browse repository at this point
Copy the full SHA b0fff67View commit details -
Merge pull request #2283 from ekohl/add-mod_auth_openidc-acceptance-test
Manage DNF module for mod_auth_openidc
Configuration menu - View commit details
-
Copy full SHA for 2603379 - Browse repository at this point
Copy the full SHA 2603379View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f3c2d8 - Browse repository at this point
Copy the full SHA 0f3c2d8View commit details -
Merge pull request #2292 from francetv/main
Allow setting icons_path to false so no alias will be set for it
Configuration menu - View commit details
-
Copy full SHA for b9547ef - Browse repository at this point
Copy the full SHA b9547efView commit details
Commits on Aug 15, 2022
-
Timeouts are more naturally written as integers, allow them.
Configuration menu - View commit details
-
Copy full SHA for 5243360 - Browse repository at this point
Copy the full SHA 5243360View commit details
Commits on Aug 17, 2022
-
Merge pull request #2294 from traylenator/timeout
Allow integers for timeouts
Configuration menu - View commit details
-
Copy full SHA for 04a914a - Browse repository at this point
Copy the full SHA 04a914aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58078cc - Browse repository at this point
Copy the full SHA 58078ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9710ef - Browse repository at this point
Copy the full SHA f9710efView commit details
Commits on Aug 18, 2022
-
Merge pull request #2276 from puppetlabs/pdksync_GH-cat-11/main/add_u…
…buntu_22.04_support pdksync - (GH-cat-11) Certify Support for Ubuntu 22.04
Configuration menu - View commit details
-
Copy full SHA for 1475cd7 - Browse repository at this point
Copy the full SHA 1475cd7View commit details -
GitHub Action committed
Aug 18, 2022 Configuration menu - View commit details
-
Copy full SHA for 9674a9d - Browse repository at this point
Copy the full SHA 9674a9dView commit details -
Merge pull request #2297 from puppetlabs/release-prep
Release prep v8.1.0
Configuration menu - View commit details
-
Copy full SHA for babf023 - Browse repository at this point
Copy the full SHA babf023View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.0.0...v8.1.0