Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-apache
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.4.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-apache
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.5.0
Choose a head ref
  • 12 commits
  • 11 files changed
  • 7 contributors

Commits on Nov 21, 2022

  1. - remove _module from apache::mod::unique_id name.

    mdklapwijk authored and mdklapwijk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    cd9673b View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. fix spec test

    mdklapwijk authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    547cbd5 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Clean up SELinux handling in acceptance testing.

    This attempts to unify SELinux handling in the tests. It moves the
    package installation to the acceptance spec helper to reduce
    duplication. It then makes the set_apache_defaults line idempotent and
    restorecon_apache correctly chained. This works around [PUP-10548] which
    is that Puppet doesn't reload file contexts within a run. That means it
    must first create the file(s) and then run restorecon to get correct
    contexts.
    
    [PUP-10548]: https://tickets.puppetlabs.com/browse/PUP-10548
    ekohl committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    12ab304 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Configuration menu
    Copy the full SHA
    08fd949 View commit details
    Browse the repository at this point in the history
  2. fix typo

    stefan-ahrefs committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1eb13d2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2fa1fd4 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Configuration menu
    Copy the full SHA
    29faa1a View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge pull request #2320 from ekohl/clean-up-selinux-in-acceptance

    Clean up SELinux handling in acceptance testing.
    david22swan authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    9aabe24 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2345 from stefan-ahrefs/main

    add LimitRequestLine parameter
    david22swan authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    255b005 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2339 from mdklapwijk-forks/patch-mod-security-uni…

    …que_id-naming
    
    remove _module from apache::mod::unique_id name.
    david22swan authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    1d2302d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. disable::mpm_event: Fix module deactivation

    there were a few things broken:
    * a2dismod was called with the wrong module name. at least on apache
      2.4.54 on Debian 11 it is named mpm_event, not event
    * the paths to the files were wrong
    * a2dismod already purges the .load and .conf file, the exec resources
      are not required (even then a file resource would probably be cleaner
      to purge them)
    * Apache needs to be reloaded, so just running this priot to
      apache2::service isn't enough, it needs to be a notify
    
    This initially worked but was changed from mpm_event to event in
    #1961. Then it was
    fixed in #2034 by
    adding the exec resources, but the actual a2dismod was still broken.
    bastelfreak committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1797602 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2349 from bastelfreak/mpm_event

    disable::mpm_event: Fix module deactivation
    david22swan authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    0b74e1d View commit details
    Browse the repository at this point in the history
Loading