Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-apache
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.1.1
Choose a base ref
...
head repository: puppetlabs/puppetlabs-apache
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.1.2
Choose a head ref
  • 18 commits
  • 24 files changed
  • 6 contributors

Commits on Feb 3, 2023

  1. Suppress bad Directory comment when DocumentRoot is not set. 

    It's valid for a DocumentRoot to be missing (docroot => false).
However, in the directories section, this leads to a confusing message:
"## Directories, there should at least be a declaration for false"
    @gcoxmoz
    gcoxmoz committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    631f7fb View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Merge pull request #2368 from gcoxmoz/docroot-comment 

    Suppress bad Directory comment when DocumentRoot is not set
    @pmcmaw
    pmcmaw authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    04d7b51 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Fix example code for apache::vhost::php_values 

    The `php_values` parameter requires a Hash, but gives examples from the ~v7 era when other values were allowed.
    @gcoxmoz
    gcoxmoz committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    113ecc0 View commit details
    Browse the repository at this point in the history

  2. fix rewrite rules being ignored 

    In 7b22dae the default value for $rewrites was changed
from undef to [] in manifests/vhost.pp. This results
in templates_vhost/_rewrite.erb always evaluating to
false (boolean check on an empty array variable is
still true) unless $rewrites is explicitly set to undef.
This results in the content of $rewrite_rule being ignored.

closes: #2318
    @trefzer
    trefzer committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    4a884c7 View commit details
    Browse the repository at this point in the history

  3. add rspec tests

    @trefzer
    trefzer committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    c25a58a View commit details
    Browse the repository at this point in the history

  4. use ! instead of not

    @trefzer
    trefzer committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    faeac60 View commit details
    Browse the repository at this point in the history

  5. fix superflous ')'

    @trefzer
    trefzer committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    6c0267e View commit details
    Browse the repository at this point in the history

  6. Fixes mod::proxy allow_from parameter inconsistency #2352 

    apache::mod::proxy allowed Stdlib::IP::Address as a class parameter, but
proxy.conf.erb assumed it was an array.
    @pebtron
    pebtron committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    33027f8 View commit details
    Browse the repository at this point in the history

  7. fix 'Space inside parentheses'

    @trefzer
    trefzer committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    21c9091 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. fix spec test add missing negation of test

    @trefzer
    trefzer committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    a0580b5 View commit details
    Browse the repository at this point in the history

  2. escape special chars in regex spec tests

    @trefzer
    trefzer committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2aa7689 View commit details
    Browse the repository at this point in the history

  3. (BUGFIX) Update to ensure correct facter comparisons 

    Ensuring that the correct values are compared against facter, there seem to be many cases where lowercase has been used in place of uppercase.
    @david22swan
    david22swan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    290e096 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Merge pull request #2387 from david22swan/bugfix/facter_case_fix 

    (BUGFIX) Update to ensure correct facter comparisons
    @pmcmaw
    pmcmaw authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f618243 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2385 from pebtron/main 

    Fixes mod::proxy allow_from parameter inconsistency #2352
    @david22swan
    david22swan authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e774bc7 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2384 from gcoxmoz/php_values-doc 

    Fix example code for apache::vhost::php_values
    @david22swan
    david22swan authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    4086506 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2330 from cirrax/fix_rewrite 

    fix rewrite rules being ignored
    @david22swan
    david22swan authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ab0d406 View commit details
    Browse the repository at this point in the history

  5. Release prep v9.1.2

    GitHub Action committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    cd1119c View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2388 from puppetlabs/release-prep 

    Release prep v9.1.2
    @david22swan
    david22swan authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    0f7fe11 View commit details
    Browse the repository at this point in the history
Loading