Feature/master/passengerbaseuri #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -385,6 +386,13 @@ | |||
| } | |||
| } | |||
|
|
|||
| # Load mod_passenger if needed and not yet loaded | |||
| if $passenger_base_uris { | |||
| if ! defined(Class['apache::mod::passenger']) { | |||
There was a problem hiding this comment.
You don't need to have this check, include ::apache::mod::passenger will just work.
|
@aronymous thanks for the contribution! This needs a rebase, squash, and tests before this can be merged. |
aronymous
force-pushed
the
feature/master/passengerbaseuri
branch
from
1a66e50
to
b300a08
Compare
|
I added tests and made the changes suggested. Hope I did it right. Thanks |
|
Hi @aronymous , This still needs a squash, there is some pretty good documentation here |
This adds a varaible and template block for using PassengerBaseURI in the vhost
aronymous
force-pushed
the
feature/master/passengerbaseuri
branch
from
b300a08
to
9367580
Compare
| @@ -386,6 +387,11 @@ | |||
| } | |||
| } | |||
|
|
|||
| # Load mod_passenger if needed and not yet loaded | |||
| if $passenger_base_uris { | |||
| include ::apache::mod::passenger | |||
There was a problem hiding this comment.
4 spaces should be 2 space indentation.
underscorgan
pushed a commit
that referenced
this pull request
Sep 17, 2015
Feature/master/passengerbaseuri
|
Thanks @aronymous |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(MODULES-2188) Add support for PassengerBaseURI in Apache