(MODULES-2419) - Add mod_auth_kerb parameters to vhost #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| auth_name => 'Kerberos Login', | ||
| auth_type => 'Kerberos', | ||
| auth_require => 'valid-user', | ||
|
|
There was a problem hiding this comment.
Can you fix the arrow alignment here? There should be a newline after {, only one level of indentation for the hash key/values, and the hash arrows should be aligned independently from the resource attribute arrows.
|
If you could add tests too, that would be great! |
|
|
|
||
| ~~~ puppet | ||
| apache::vhost {'sample.example.net': | ||
| auth_kerb => true, |
|
@traylenator Can you fix the remaining formatting nits and also squash your commits? Thanks! |
|
README.md formatting hopefully okay now and trailing comma inserted. Thanks for the review. |
https://tickets.puppetlabs.com/browse/MODULES-2419 The following kerberos parameters can be set within a vhost. KrbMethodNegotiate KrbMethodK5Passwd KrbAuthoritative KrbAuthRealms Krb5Keytab KrbLocalUserMapping Reference for mod_auth_kerb: http://modauthkerb.sourceforge.net/configure.html https://bugzilla.redhat.com/show_bug.cgi?id=970678
|
Thanks @traylenator ! |
bmjen
added a commit
that referenced
this pull request
Sep 14, 2015
(MODULES-2419) - Add mod_auth_kerb parameters to vhost
|
TThanks @bmjen - any idea when there will be a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/MODULES-2419
The following kerberos parameters can be set within
a vhost.
KrbMethodNegotiate
KrbMethodK5Passwd
KrbAuthoritative
KrbAuthRealms
Krb5Keytab
KrbLocalUserMapping
Reference for mod_auth_kerb:
http://modauthkerb.sourceforge.net/configure.html
https://bugzilla.redhat.com/show_bug.cgi?id=970678