(MODULES-2647) Optinally set parameters for mod_ext_filter module #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class{'apache::mod::ext_filter': | ||
| ext_filter_define => { 'slowdown' => 'mode=output cmd=/bin/cat preservescontentlength', | ||
| 'puppetdb-strip' => 'mode=output outtype=application/json cmd="pdb-resource-filter"'}, | ||
| } |
There was a problem hiding this comment.
i'd rather write this as:
class { 'apache::mod::ext_filter':
ext_filter_define => {
'slowdown' => 'mode=output cmd=/bin/cat preservescontentlength',
'puppetdb-strip' => 'mode=output outtype=application/json cmd="pdb-resource-filter"',
},
}There was a problem hiding this comment.
Indeed. Squashed also.
Permits the
* ExtFilterDefine to be set multiple times on a server.
* ExtFilterOptions to be set on a directory context.
```puppet
class{'apache':
default_mods => false,
directories => [
{ path => '/var/www/filter',
ext_filter_options => 'LogStderr Onfail=abort',
},
],
}
class{'apache::mod::ext_filter':
ext_filter_define => {
'slowdown' => 'mode=output cmd=/bin/cat preservescontentlength',
'puppetdb-strip' => 'mode=output outtype=application/json cmd="pdb-resource-filter"',
},
}
```
* https://tickets.puppetlabs.com/browse/MODULES-2647
* http://httpd.apache.org/docs/current/mod/mod_ext_filter.html
igalic
added a commit
that referenced
this pull request
Sep 30, 2015
(MODULES-2647) Optinally set parameters for mod_ext_filter module
|
thanks a lot @traylenator! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permits the