Change SSLProtocol in apache::vhost to be space separated #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ | |||
| SSLProxyEngine On | |||
| <%- end -%> | |||
| <%- if @ssl_protocol -%> | |||
| SSLProtocol <%= @ssl_protocol %> | |||
| SSLProtocol <%= @ssl_protocol.compact.join(' ') %> | |||
There was a problem hiding this comment.
i'd go as far as to make it
[@ssl_protocol].flatten.compact.join(' ')especially since the tests fail because of
Detail: undefined method `compact' for "SSLv2":String
|
Hello @bmfurtado , |
…ocol for apache::vhost.
|
@HelenCampbell I've added an acceptance test and updated the docs, is this ok? |
|
Disclaimer: For reasons I haven't had time to investigate I can't run the tests and it doesn't look like Travis runs acceptance tests (for some reason?) so I'm not really sure this works :) |
igalic
added a commit
that referenced
this pull request
Oct 13, 2015
Change SSLProtocol in apache::vhost to be space separated
|
Let's see :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/MODULES-2655