(#2673) Adding dev_packages to apache class. Allows use of httpd24u-d… #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this change looks good to me, but please add a note to the README reference section explaining the new parameter. Do not forget to squash your changes into a single commit: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits |
|
Ok, I've updated README.md and squashed my commits down to a single one. Thanks, |
| apache_name => 'httpd24u', | ||
| dev_packages => 'httpd24u-devel', | ||
| } | ||
| ~~~ |
There was a problem hiding this comment.
Wouldn't you also need to include the apache::dev class?
…pd24u-devel from the IUS repo. Adding documentation to README for dev_packages param to the apache class. Adding include apache::dev to example for dev_packages param.
|
Yes, I've updated the README. |
DavidS
added a commit
that referenced
this pull request
Oct 13, 2015
(#2673) Adding dev_packages to apache class. Allows use of httpd24u-d…
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…evel from the IUS repo.