(MODULES-2120) Allow empty docroot #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakatz
force-pushed
the
feature/master/allow_no_docroot
branch
from
e146f60
to
b5ee6d7
Compare
|
Please add a sentence or two to the README explaining this change. If also someone familiar with that change (@igalic, @roidelapluie ) could have a second look, I'd be grateful. |
yakatz
force-pushed
the
feature/master/allow_no_docroot
branch
from
b5ee6d7
to
22be98c
Compare
README.md updated If `docroot` and [`manage_docroot`][] are both set to `false`, no [`DocumentRoot`][] will be set and the accompanying `<Directory /path/to/directory>` block will not be created.
yakatz
force-pushed
the
feature/master/allow_no_docroot
branch
from
22be98c
to
f57f7f7
Compare
|
README updated. |
|
this looks good! @yakatz you might wanna add this commit's email to your github settings, for extra magick internet points |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a single commit version of a similar pull request.
Ignoring the document root requires setting both docroot and manage_docroot to false.