(MODULES-2757) Adding if around ServerName in template

[damonconway]

Changing template to wrap ServerName in an if statement so you can set $::apache::vhost::servername to false and skip adding ServerName to the config.

[igalic]

@damonconway what's the benefit of doing that?

---

<igalic> fajita: servername default
<fajita> The default value for ServerName in the virtual host context is the
  ServerName in the server context. The default value for the ServerName in
  the server context is the hostname of the server

[damonconway]

As I explained in the ticket, we were unable to get the cluster module
packaged with jboss enterprise to work unless we completely removed the
ServerName line. I tried a servername of default, but that didn't work
either.

Thanks,
Damon

On Thu, Oct 29, 2015 at 8:30 AM, Igor Galić notifications@github.com
wrote:

@damonconway https://github.com/damonconway what's the benefit of doing
that?

—
Reply to this email directly or view it on GitHub
#1237 (comment)
.

[igalic]

nod

would you mind rebasing?

[damonconway]

Absolutely. I've not done a rebase before. I assume you want me to bring my branch up to date with master, correct?

[damonconway]

Found the docs and did the rebase.

[igalic]

thanks @damonconway!