(MODULES-2764) Enclose IPv6 addresses in square brackets #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,38 @@ | |||
| # | |||
| # enclose_ipv6.rb | |||
| # | |||
There was a problem hiding this comment.
this new function needs spec tests
There was a problem hiding this comment.
I'll see what I can do tomorrow
There was a problem hiding this comment.
@igalic I've added some spec tests
There was a problem hiding this comment.
@igalic Have you had time to review the changes?
The apache module does enclose IPv6 addresses in square brackets as apache recommends Apache 2.2: https://httpd.apache.org/docs/2.2/en/bind.html https://httpd.apache.org/docs/2.2/en/mod/core.html#virtualhost https://httpd.apache.org/docs/2.2/en/mod/core.html#namevirtualhost Apache 2.4: https://httpd.apache.org/docs/2.4/en/bind.html https://httpd.apache.org/docs/2.4/en/mod/core.html#virtualhost added some tests for the custom function enclose_ipv6
Benedikt1992
force-pushed
the
ticket/2764-Enclose_IPv6_addresses_in_square_brackets
branch
from
94c8218
to
55cc3b4
Compare
igalic
added a commit
that referenced
this pull request
Nov 11, 2015
…ddresses_in_square_brackets (MODULES-2764) Enclose IPv6 addresses in square brackets
|
thank you very much @Benedikt1992 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apache module does enclose IPv6 addresses in square brackets as
apache recommends
Apache 2.2:
https://httpd.apache.org/docs/2.2/en/bind.html
https://httpd.apache.org/docs/2.2/en/mod/core.html#virtualhost
https://httpd.apache.org/docs/2.2/en/mod/core.html#namevirtualhost
Apache 2.4:
https://httpd.apache.org/docs/2.4/en/bind.html
https://httpd.apache.org/docs/2.4/en/mod/core.html#virtualhost
Ticket: https://tickets.puppetlabs.com/browse/MODULES-2764