Leave require directive unmanaged #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'path' => '/var/www/files_nrag', | ||
| 'provider' => 'files', | ||
| 'require' => 'unmanaged', | ||
| }, |
There was a problem hiding this comment.
this seems needlessly duplicated, and is unused
Instead to default require to 'Require all granted' if no 'require' parameter is set for a directory, leave require unmanaged in apache 2.4 if needed. This is useful for complex authentication/authorization requirements which are handled in a custom fragment.
robertvargason
force-pushed
the
require_unmanaged
branch
from
7d0beeb
to
f35a65d
Compare
igalic
added a commit
that referenced
this pull request
Nov 18, 2015
Leave require directive unmanaged
|
thanks @robertvargason! |
|
Thanks for this PR, I spent a lot of time searching to find how not to have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead to default require to 'Require all granted' if no 'require'
parameter is set for a directory, leave require unmanaged in apache 2.4
if needed. This is useful for complex authentication/authorization
requirements which are handled in a custom fragment.