(MODULES-2682, FM-3919) Use more FilesMatch #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilesMatch and AddHandler do not interact correctly, which caused the fcgi tests to (correctly) complain about php-cgi not being started for the fcgi configuration. Using FilesMatch in all cases addresses both the original security issue (better) and leads to correct resolution of handlers again.
mentat
added a commit
that referenced
this pull request
Nov 30, 2015
(MODULES-2682, FM-3919) Use more FilesMatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilesMatch and AddHandler do not interact correctly, which caused the fcgi
tests to (correctly) complain about php-cgi not being started for the fcgi
configuration.
Using FilesMatch in all cases addresses both the original security issue
(better) and leads to correct resolution of handlers again.