Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X-Forwarded-For into log_formats defaults #1308

Merged
merged 1 commit into from Jan 4, 2016

Conversation

mpolenchuk
Copy link
Contributor

In order to log the X-Forwarded-For client ip address or the real
client ip address add LogFormats default directive.

In order to log the X-Forwarded-For client ip address or the real
client ip address add LogFormats default directive.
@HelenCampbell
Copy link
Contributor

Hey @mpolenchuk , thank you for your contribution. However before I merge this all tests would need to have passed, and this change would also require a documentation update.

@bmjen
Copy link
Contributor

bmjen commented Jan 4, 2016

@mpolenchuk @HelenCampbell The pcci-trusty test failure can be ignored, I've already fixed the fastcgi problem in master. I'll merge as everything else looks ok.

bmjen added a commit that referenced this pull request Jan 4, 2016
Add X-Forwarded-For into log_formats defaults
@bmjen bmjen merged commit a78617b into puppetlabs:master Jan 4, 2016
@antaflos
Copy link
Contributor

antaflos commented Feb 2, 2016

@mpolenchuk shouldn't that be %>s instead of just %s? Both common and combined use %>s so forwarded should follow suit, no?

@mpolenchuk
Copy link
Contributor Author

@antaflos in terms of sameness yes. I've overlooked it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants