-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fcgid.conf on Debian #1331
Fix fcgid.conf on Debian #1331
Conversation
|
@DavidS is this related to any apache problem you were seeing on debian? |
|
@jonnytpuppet the debian problems I've been working on are related to service management and https://tickets.puppetlabs.com/browse/PUP-5016 . This looks more intricate. |
| :operatingsystemrelease => '10', | ||
| :operatingsystemmajrelease => '10', | ||
| :operatingsystemrelease => '9', | ||
| :operatingsystemmajrelease => '9', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come you changed this from 10 to 9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the revert of your commit that didn't explain the reason of this change.
I can apply it again, once I know what you wanted to fix.
|
once the revert is successful, i'm happy to change this to add freebsd to the redhat condition. that being said, it was completely reasonable to implement this as a default instead of just for RH and freebsd, since it is required to load mod_unixd before mod_fcgid. |
Fix the regression from 1bf0aba (see puppetlabs#879).
|
I think this new commit fixes all the remarks:
|
|
Thanks @sathieu ! |
Fixes #1178 regression on Debian: the conf symlink was missing.