Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fcgid.conf on Debian #1331

Merged
merged 1 commit into from
Feb 8, 2016
Merged

Fix fcgid.conf on Debian #1331

merged 1 commit into from
Feb 8, 2016

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Jan 15, 2016

Fixes #1178 regression on Debian: the conf symlink was missing.

@jonnytdevops
Copy link
Contributor

@DavidS is this related to any apache problem you were seeing on debian?

@DavidS
Copy link
Contributor

DavidS commented Jan 18, 2016

@jonnytpuppet the debian problems I've been working on are related to service management and https://tickets.puppetlabs.com/browse/PUP-5016 . This looks more intricate.

:operatingsystemrelease => '10',
:operatingsystemmajrelease => '10',
:operatingsystemrelease => '9',
:operatingsystemmajrelease => '9',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come you changed this from 10 to 9?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the revert of your commit that didn't explain the reason of this change.

I can apply it again, once I know what you wanted to fix.

@sethlyons
Copy link
Contributor

once the revert is successful, i'm happy to change this to add freebsd to the redhat condition. that being said, it was completely reasonable to implement this as a default instead of just for RH and freebsd, since it is required to load mod_unixd before mod_fcgid.

@sathieu
Copy link
Contributor Author

sathieu commented Feb 6, 2016

I think this new commit fixes all the remarks:

  • It now works again on Debian
  • @sethlyons I uses unixd_fcgid on FreeBSD
  • @bmjen it's rebased and squashed

@bmjen
Copy link
Contributor

bmjen commented Feb 8, 2016

Thanks @sathieu !

bmjen added a commit that referenced this pull request Feb 8, 2016
@bmjen bmjen merged commit 7f2b6b8 into puppetlabs:master Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants