fix vhosts listen to wildcard ip #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| return result.flatten.compact |
There was a problem hiding this comment.
It would be appreciated if you could explain why it is ok that this can be removed, and how it related to wildcard vhosts, thanks!
There was a problem hiding this comment.
It's because I changed result = [result,val] to result << val which makes more sense. input is already flattened in line 27, so we do not need to flatten it once again.
jonnytdevops
added a commit
that referenced
this pull request
Jan 19, 2016
fix vhosts listen to wildcard ip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently fails. This PR fixes the behavior.