Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apache_version fact #1347

Merged
merged 1 commit into from Feb 3, 2016
Merged

Add apache_version fact #1347

merged 1 commit into from Feb 3, 2016

Conversation

jyaworski
Copy link

No description provided.

bmjen added a commit that referenced this pull request Feb 3, 2016
@bmjen bmjen merged commit 5a1fdd3 into puppetlabs:master Feb 3, 2016
@bmjen
Copy link
Contributor

bmjen commented Feb 3, 2016

Thanks @jyaworski !

@jyaworski jyaworski deleted the add_apache_version_fact branch February 3, 2016 21:00
Facter.add(:apache_version) do
setcode do
if Facter::Util::Resolution.which('apachectl')
apache_version = Facter::Util::Resolution.exec('apachectl -v 2>&1')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on older versions of Debuntu, this will not work, because they renamed their apachectl to apache2ctl

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How old is 'older'? 7?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not work, but then it will just be undef so same ol' same ol'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.2, so prior ubuntu 13.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants