Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed rpaf Configuration Directives: RPAF -> RPAF_ #1361

Merged
merged 1 commit into from
Feb 19, 2016
Merged

changed rpaf Configuration Directives: RPAF -> RPAF_ #1361

merged 1 commit into from
Feb 19, 2016

Conversation

gvdb1967
Copy link
Contributor

@gvdb1967 gvdb1967 commented Feb 5, 2016

mod_rpaf: I changed the names of the different configuration directives as described on https://github.com/gnif/mod_rpaf
modified files:
spec/classes/mod/rpaf_spec.rb
templates/mod/rpaf.conf.erb

os: rhel/centos 6

  • httpd-2.2
  • mod_rpaf

@gvdb1967
Copy link
Contributor Author

gvdb1967 commented Feb 8, 2016

bundle exec rake spec
Finished in 10 minutes 45 seconds (files took 2.01 seconds to load)
1263 examples, 0 failures

tphoney added a commit that referenced this pull request Feb 19, 2016
changed rpaf Configuration Directives: RPAF -> RPAF_
@tphoney tphoney merged commit 61774eb into puppetlabs:master Feb 19, 2016
@antaflos
Copy link
Contributor

This was a very bad call and breaks Apache/mod_rpaf for those of us that use Apache 2.2 on Ubuntu 12.04, where the configuration directives are, as per the documentation of libapache2-mod-rpaf, like this (from /usr/share/doc/libapache2-mod-rpaf/README):

RPAFenable On
# Enable reverse proxy add forward
RPAFproxy_ips 127.0.0.1 10.0.0.1
# which ips are forwarding requests to us
RPAFsethostname On
# let rpaf update vhost settings 
# allows to have the same hostnames as in the "real"
# configuration for the forwarding Apache
RPAFheader X-Forwarded-For
# Allows you to change which header mod_rpaf looks
# for when trying to find the ip the that is forwarding
# our requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants