Support socket communication option in apache::fastcgi::server

[janschumann]

For local fcgi servers it makes sense to skip the TCP stack and communicate via socket.

This is also sugested in #MODULES-1405.

Instead of introducing a new parameter socket, validate functions are used to decide if we have a host or a socket in parameter host.

It might be confusing to pass a socket path to a parameter named host, but changing the host parameter name to something like host_or_socket would introduce backwards incompatibility.

[hunner]

Perhaps this would be more accurately $is_socket?

[hunner]

Or even ditch the whole $is_whatever and go for:

if is_absolute_path($host) {
  $socket = $host
} else {
  $split = split($host, ':')
  validate_ip_address($split[0])
  $_host = $host
}

Then

<%= if @_host then " -host" end %><%= if @socket then " -socket" end %>

which leaves room for other types. Are there types other than host or socket?

[tphoney]

@janschumann is there anything else we can help with ?

[janschumann]

@tphoney No thanks, but sorry for the delay. I am waiting until #1370 has been merged.

[janschumann]

@hunner: afaik there are only tcp and socket connection options available ...

[janschumann]

@hunner rebased and squashed

[hunner]

@janschumann Thanks. Could you also mention the new functionality in https://github.com/puppetlabs/puppetlabs-apache#host-1 ?

[janschumann]

@hunner docs added. I also removed the ip validation of the host parameter, as it may also be a hostname :-)

[hunner]

Good point.

[janschumann]

@hunner thanks for merging!