support pass-header option in apache::fastcgi::server

[janschumann]

No description provided.

[hunner]

Could you actually change these two -%>\n<%- to just %> <% so they're on the same line? It seems a little confusing to have them be on two lines if you want the output to be a single line, and flush is already setting precedent for single-line code. Thanks!

[janschumann]

Yes it is a bin confusing. But isn´t the readability of the template also a criteria?

Please see #1368 .. This line might get even longer.

Thoughts?

[hunner]

Ah yeah, if there are lots of options to pass then the other option is to pre-set all the variables in a <% %> block before the line to the full string like

<%
  timeout = " -idle-timeout #{@timeout}"
  host = " -host #{@host}"
  if @pass_header and ! @pass_header.empty?
    pass_header = " -pass-header #{@pass_header}"
  else
    pass_header = ""
  end
  #...
  options =  timeout + flush + host + pass_header
%>
FastCGIExternalServer <%= @faux_path %><%= options %>`

[janschumann]

agreed. i´ll do that.

[hunner]

Sorry for the late response on this. Could you document your new parameter in the readme as well?

[janschumann]

Sure.

While looking into the documentation of mod_fastcgi, I realized that there are some more options available, such as appConnTimeout and user etc.. Do you want this module to be as comprehensive as possible, or do you tend to implement options, when they are needed/requested.

Let me know, if you want me to implement the remaining options.

[hunner]

It's okay as-is; I always say to write for future extensibility, but present simplicity :).

👍