Manage mod dir before things that depend on mods #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu Trusty, the default mpm module is "event". In
puppetlabs-apache, the default mpm module is "worker". These can't both
be loaded at once. The apache puppet module takes care of this by
purging the mods-enabled directory. However, if we try to run a syntax
check before the directory is purged, it fails. The
apache::custom_config defined type contains an "syntax verification for
${name}" exec that can potentially run before the event mod is unloaded.
This patch ensures that the module purging occurs before syntax check
happens so that the puppet run is successful.
hunner
added a commit
that referenced
this pull request
Mar 9, 2016
Manage mod dir before things that depend on mods
openstack-gerrit
pushed a commit
to openstack-infra/puppet-infracloud
that referenced
this pull request
Apr 12, 2016
Since the infracloud::logs class was added, fresh installs suffer from a bug causing puppet to fail trying to check apache syntax in the middle of a run[1]. This patch is a temporary fix while we wait for the upstream apache module to be fixed. [1] puppetlabs/puppetlabs-apache#1388 Change-Id: I558756e4704d3b3e090db92edfeca6f75def1e04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu Trusty, the default mpm module is "event". In
puppetlabs-apache, the default mpm module is "worker". These can't both
be loaded at once. The apache puppet module takes care of this by
purging the mods-enabled directory. However, if we try to run a syntax
check before the directory is purged, it fails. The
apache::custom_config defined type contains an "syntax verification for
${name}" exec that can potentially run before the event mod is unloaded.
This patch ensures that the module purging occurs before syntax check
happens so that the puppet run is successful.