Allow package names to be specified for mod_proxy, mod_ldap, and mod_authnz_ldap #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a quite trivial change, so additional spec coverage is not really required. What you should do, though, is adding the params to the README, so people can find them, and do not need to guess. |
|
Updated the README. Sorry for the delay. |
|
With the recent merges, you will need to rebase this. Many apologies. |
|
No problem. Learned something new :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to allow users to change the package name on the aforementioned mods. This is based on the code for mod::ssl, which already had this feature.
I'm not (very) experienced in the subject of spec tests and could use some help if those need to be improved as well. The code works as expected in my setup.