Wrap mod_security directives in an IfModule #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of casing this out (and thus potentially making it do nothing) could you cause apache::vhost to include apache::mod::security if the parameters that need it are passed? https://github.com/kimor79/puppetlabs-apache/blob/wrap_vhost_mod_security/manifests/vhost.pp#L988 |
|
My use case is I have a vhost which is added "everywhere" but mod_security is only enabled for certain roles. When mod_security is enabled I don't want it enabled for that vhost but that vhost shouldn't need to pull in mod_security just to disable it. |
kimor79
force-pushed
the
wrap_vhost_mod_security
branch
from
016c810
to
4b9f9a0
Compare
|
@hunner does this address your concern ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.