Support the newer mod_auth_cas config options #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pcfens, Overall this looks good. The new params need to be add to the README though. Thanks! |
pcfens
force-pushed
the
auth_cas_updates
branch
2 times, most recently
from
46f0b9b
to
ea5890e
Compare
|
I've added the new parameters to the README, squashed, rebased, and pushed. Thanks for the feedback. |
mod_auth_cas supports a number of per-directory options https://github.com/Jasig/mod_auth_cas/blob/master/README#L333-384 A number of the options aren't supported in directory stanzas despite what the documentation suggests. The options are supported globally and in vhost configurations, so they're supported there accordingly. https://github.com/Jasig/mod_auth_cas/blob/master/README#L386-413
|
Thanks for the work !!! it is much appreciated ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod_auth_cas supports a number of per-directory options
A number of the options aren't supported in directory stanzas despite what the documentation suggests. The only way I was able to figure out what was supported was through trial and error. I've added the non-directory directives to the global and vhost configurations so that they're still available.