setting options-hash in proxy_pass or proxy_match leads to syntax errors in Apache

[zivis]

Revert "MODULES-2956: Enable options within location block on proxy_match"

this commit removes the location directive in _proxy.erb
proxy: remove workaround for old broken clients
99add11

this commit sets options in the location directive in _proxy.erb
MODULES-2956: Enable options within location block on proxy_match
db5b0bf

setting options-hash in proxy_pass or proxy_match now leads to syntax errors
in Apache like "AuthBasicProvider not allowed here"

[bmjen]

/cc @igalic Can we get your expertise here. Did the PRs described break functionality?

[antaflos]

Just to chime in here, reverting db5b0bf definitely seems like the right thing to do. It apparently was a crutch to work around the suboptimal behaviour of _proxy.erb.

But now that _proxy.erb no longer implements that ancient workaround of putting ProxyPassReverse inside its own Location directive there is really neither need nor use in trying to define options that are only valid inside a Location or Directory context. The options functionality for proxy_pass can be scrapped entirely.

Any options such as AuthBasicProvider, AuthType, Require, ... are supported by the apache::vhost::directories parameter, where they belong.

[igalic]

👍 thanks, @antaflos for jumping in