Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_event: do not set parameters twice #1445

Merged

Conversation

timogoebel
Copy link
Contributor

The Name of the Parameters MaxRequestWorkers and MaxConnectionsPerChild for mod_event changed between versions as the README already shows (mixed up though).
The apache module should not set both the old and the new parameter name, but instead just one of them.

The old names are still supported so it's better (and safe) to set the old names than both.

See:

@jonnytdevops
Copy link
Contributor

@hunner @bmjen Do you agree that this is a breaking change as the defaults are being removed?

Thanks!

@timogoebel
Copy link
Contributor Author

@jonnytpuppet : Thanks for taking a look. I don't think this breaks anything. It just prefers the "newer" parameter names.

@jonnytdevops
Copy link
Contributor

@timogoebel The default values are being removed for these values, though?
Thanks

@timogoebel
Copy link
Contributor Author

@jonnytpuppet : Yes, but $maxconnectionsperchild = $maxrequestsperchild = 0 ($maxconnectionsperchild was 0 before the change) --> nothing really happend, the parameter is just not set twice

@jonnytdevops jonnytdevops merged commit 5bcf4f3 into puppetlabs:master May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants