Revert "changed rpaf Configuration Directives: RPAF -> RPAF_" #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8ca7a66. These changes are completely incompatible with mod_rpaf as provided in Ubuntu 12.04 and Debian Jessie and Wheezy, and break the Apache configuration and consequently the Puppet agent run. I suspect these changes were made to be compatible with one of the mod_rpaf forks (https://github.com/gnif/mod_rpaf) but I don't see how a "random" fork should have precedence over, and break modules distributed on the official channels.
|
This is also problematic for FreeBSD. |
|
+1 |
|
Thanks for catching and fixing this @antaflos . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8ca7a66.
These changes are completely incompatible with mod_rpaf as provided in
Ubuntu 12.04 and Debian Jessie and Wheezy, and break the Apache
configuration and consequently the Puppet agent run.
I suspect these changes were made to be compatible with one of the
mod_rpaf forks (https://github.com/gnif/mod_rpaf) but I don't see how a
"random" fork should have precedence over, and break modules distributed
on the official channels.