apache::balancer now respects apache::confd_dir #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :concat_basedir => '/dne', | ||
| :path => '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin', | ||
| :kernel => 'Linux', | ||
| :is_pe => false, |
There was a problem hiding this comment.
These seem to be the same facts as above? Please put them into the outer describe block, and avoid the duplication.
There was a problem hiding this comment.
Yes - fixed and re-based.
|
Good catch, and thanks for the test! |
traylenator
changed the title
Previously with a configuration of
```
class{'apache':
confd_dir => '/my/directory':
}
balancer{'myb':}
```
balencer would create a file incorrectly in the default location
*/etc/apache2/conf.d/balancer_myb.conf*
balencer now uses the value *apache::confd_dir*.
A test case has been added for this bug.
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously with a configuration of
balencer would create a file incorrectly in the default location
/etc/apache2/conf.d/balancer_myb.conf
balencer now uses the value apache::confd_dir.
A test case has been added for this bug.