Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cas_cookie_path_mode param #1475

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Add cas_cookie_path_mode param #1475

merged 1 commit into from
Jul 1, 2016

Conversation

edestecd
Copy link
Contributor

@edestecd edestecd commented Jun 8, 2016

We need this to open up write to all in the apache group.

@tphoney
Copy link
Contributor

tphoney commented Jun 16, 2016

@edestecd great work here. I have a couple of suggested changes:

  • could you squash your commits
  • could you edit the readme to add the new attributes to the documentation line 1417-1430
    Other than that, thanks for the effort and time you put in.

@tphoney tphoney closed this Jun 17, 2016
@tphoney tphoney reopened this Jun 17, 2016
@tphoney
Copy link
Contributor

tphoney commented Jun 17, 2016

wooops, accidental close

@edestecd
Copy link
Contributor Author

@tphoney squashed and readme updated

@tphoney
Copy link
Contributor

tphoney commented Jun 21, 2016

@edestecd thanks for the work !!! unfortunately the code base has moved on, you will need to rebase.

cas_cookie_path_mode
cas_validate_server
@edestecd
Copy link
Contributor Author

@tphoney rebased!

@edestecd
Copy link
Contributor Author

I'm not sure why the test are failing. It looks like a network connectivity issue with ssh and not related to my code changes...

@edestecd
Copy link
Contributor Author

Can you force a rerun of the tests?

@tphoney
Copy link
Contributor

tphoney commented Jun 22, 2016

re-run, i will look into it tomorrow, if the tests continue to fail

@edestecd
Copy link
Contributor Author

looks like other PRs fail with similar errors, not sure how my change could have caused httpd to not be installed or the service not started etc. Looks like a very systemic issue.

@tphoney
Copy link
Contributor

tphoney commented Jun 22, 2016

@edestecd there is a possible issues in the latest specinfra, that could be affecting this. We have a possible fix in flight.

@edestecd
Copy link
Contributor Author

@tphoney Awesome, thanks for your help on this.

@DavidS DavidS merged commit f39416d into puppetlabs:master Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants