Auto load Apache::Mod[slotmem_shm] and Apache::Mod[lbmethod_byrequest… #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update your spec test with something like https://github.com/puppetlabs/puppetlabs-apache/blob/master/spec/classes/mod/worker_spec.rb#L4-L6 so the variable is available to use? |
|
And could you document the new parameter in README.md similar to the other mods with parameters? And describe the 4 different schedulers available with a link to https://httpd.apache.org/docs/current/mod/mod_proxy_balancer.html ? Thanks! |
|
@hunner @binford2k Comments addressed. |
sathieu
force-pushed
the
balancer24
branch
2 times, most recently
from
549129f
to
5df9143
Compare
…s] with proxy_balancer on 2.4
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s] with proxy_balancer on 2.4