add passenger_max_requests option per vhost #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR actually extends this one #1510 |
Reamer
reviewed
Oct 6, 2016
| @@ -383,6 +383,7 @@ | |||
| 'passenger_app_env' => 'test', | |||
| 'passenger_ruby' => '/usr/bin/ruby1.9.1', | |||
| 'passenger_min_instances' => '1', | |||
| 'passenger_max_requests' => '1000', | |||
There was a problem hiding this comment.
It's similar to this configuration from apache.
https://httpd.apache.org/docs/2.4/en/mod/mpm_common.html#maxconnectionsperchild
Therefore you should set a non-zero value.
There was a problem hiding this comment.
My bad, did'nt realized this was in the spec directory!
Checking that this produce the expected configuration would have helped me detect this 😉
smortex
approved these changes
Jul 17, 2017
eputnam
requested changes
Jul 19, 2017
README.md
Outdated
| @@ -2553,6 +2553,10 @@ Sets [PassengerRuby](https://www.phusionpassenger.com/library/config/apache/refe | |||
|
|
|||
| Sets [PassengerMinInstances](https://www.phusionpassenger.com/library/config/apache/reference/#passengermininstances), the minimum number of application processes to run. | |||
|
|
|||
| ##### `passenger_max_requests | |||
|
@eputnam I synced my repo with upstream and reapplied my changes on top of that so it's mergeable. |
eputnam
approved these changes
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel Pulec kayn@inuits.eu