Allow no_proxy_uris to be used within proxy_pass #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, proxy_pass and proxy_pass_match configuration blocks did not support using no_proxy_uris and no_proxy_uris_match. These parameters required the use of proxy_dest, but mixing proxy_pass and proxy_dest results in undesired duplication of ProxyPass config lines. Fix by allowing no_proxy_uris and no_proxy_uris_match to be used within proxy_pass and proxy_pass_match configuration blocks.
|
Closes #1521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, proxy_pass and proxy_pass_match configuration blocks did not
support using no_proxy_uris and no_proxy_uris_match. These parameters
required the use of proxy_dest, but mixing proxy_pass and proxy_dest
results in undesired duplication of ProxyPass config lines.
Fix by allowing no_proxy_uris and no_proxy_uris_match to be used within
proxy_pass and proxy_pass_match configuration blocks.
This PR is similar to #1521 but addresses the problem better in my opinion.